[PWGJE] Add task for particle-level jet cross-section efficiency evaluation #14057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joonsukbae
requested review from
alibuild,
fjonasALICE,
maoyx,
mfasDa,
mhemmer-cern and
nzardosh
as code owners
|
O2 linter results: ❌ 3 errors, |
nzardosh
reviewed
Dec 2, 2025
| if (jetderiveddatautilities::selectCollision(collision, eventSelectionBits, skipMBGapEvents)) { | ||
| hasCustomEventSel = true; | ||
| } | ||
| if ((trackOccupancyInTimeRangeMin < collision.trackOccupancyInTimeRange()) && (collision.trackOccupancyInTimeRange() < trackOccupancyInTimeRangeMax)) { |
Collaborator
There was a problem hiding this comment.
these could be filters in your task I think? Also isnt this for pp? Why do you need occupancy?
Contributor
Author
There was a problem hiding this comment.
My intention was to design the task so that it remains compatible with heavy-ion datasets as well, where occupancy-related selections are often needed.
Since Run 3 analyses require an additional correction step compared to Run 2, I expect several analysers (Archita, Aimeric, Wenhui, etc.) will need this framework, so I aimed for a generic and reusable structure.
I have revised the PR so that occupancy is now implemented as an eraly filter via configuration.
nzardosh
approved these changes
Dec 3, 2025
MattOckleton
pushed a commit
to MattOckleton/O2Physics
that referenced
this pull request
Jan 14, 2026
mapalhares
pushed a commit
to mapalhares/O2Physics
that referenced
this pull request
Jan 20, 2026
fcolamar
pushed a commit
to fcolamar/O2Physics
that referenced
this pull request
Feb 4, 2026
karlazertova
pushed a commit
to karlazertova/O2Physics
that referenced
this pull request
Feb 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eventSelectionsThis enables a generic and reusable framework for computing event-selection efficiencies for cross-section normalization.